Skip to content

feat(CSidebar): add 'as' prop to CSidebar #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 31, 2024
Merged

feat(CSidebar): add 'as' prop to CSidebar #421

merged 1 commit into from
Dec 31, 2024

Conversation

matt-jb
Copy link

@matt-jb matt-jb commented Dec 30, 2024

  • CSidebar has the added as prop in this PR. The default is div for backwards compatibility.
  • CHeader and CFooter will be rewritten in future versions, so haven't made any changes there.
  • CSidebarNav alread has an as prop.
  • As indicated by the issue author, CModal consideration is a separate issue.

Closes #416

@mrholek mrholek merged commit caa1007 into coreui:main Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrholek mrholek mrholek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Components like CHeader should render using proper HTML elements
2 participants
@matt-jb @mrholek